MonsterChenzhuo commented on code in PR #4923:
URL: https://github.com/apache/seatunnel/pull/4923#discussion_r1257796874
##########
seatunnel-connectors-v2/connector-cdc/connector-cdc-base/src/main/java/org/apache/seatunnel/connectors/cdc/base/source/reader/external/IncrementalSourceStreamFetcher.java:
##########
@@ -150,11 +147,12 @@ public void close() {
private boolean shouldEmit(SourceRecord sourceRecord) {
if (taskContext.isDataChangeRecord(sourceRecord)) {
Offset position = taskContext.getStreamOffset(sourceRecord);
- TableId tableId = getTableId(sourceRecord);
+ // TableId tableId = getTableId(sourceRecord);
if (!taskContext.isExactlyOnce()) {
- log.trace(
- "The table {} is not support exactly-once, so ignore
the watermark check",
- tableId);
+ // log.trace(
+ // "The table {} is not support
exactly-once, so ignore the
+ // watermark check",
+ // tableId);
Review Comment:
The sourceRecord format of mysql cdc is not exactly the same as that of
mongodb cdc. This getTableId in mongodb or cannot be obtained causes an
exception to be thrown.
In order to be compatible, some adaptations will be made later, but now,
this problem is solved through comments first(Considering that there is a lot
of pr content at present, and there is no problem at the time of development,
with the continuous merger of new pr leading to conflicts, I need to constantly
modify the logic for this purpose.).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
