Hisoka-X commented on code in PR #7288:
URL: https://github.com/apache/seatunnel/pull/7288#discussion_r1699658428
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java:
##########
@@ -86,8 +86,11 @@ public abstract class AbstractJdbcCatalog implements Catalog
{
protected final Map<String, Connection> connectionMap;
+ protected final Boolean skipIndexWhenAutoCreateTable;
+
public AbstractJdbcCatalog(
String catalogName,
+ boolean skipIndexWhenAutoCreateTable,
Review Comment:
It's weird to put `skipIndexWhenAutoCreateTable` into constructor. It should
be a parameter when invoke `createTable` method. Eg:
```java
void createTable(TablePath tablePath, CatalogTable table, boolean
ignoreIfExists, boolean createIndex)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
