dailai commented on code in PR #7288:
URL: https://github.com/apache/seatunnel/pull/7288#discussion_r1701291673
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/catalog/AbstractJdbcCatalog.java:
##########
@@ -375,7 +371,11 @@ && listTables(tablePath.getDatabaseName())
}
@Override
- public void createTable(TablePath tablePath, CatalogTable table, boolean
ignoreIfExists)
+ public void createTable(
Review Comment:
> Please do not change the existed interface. Why not create new method?
>
> ```java
> void createTable(TablePath tablePath, CatalogTable table, boolean
ignoreIfExists, boolean createIndex)
> ```
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
