Hisoka-X commented on code in PR #7273:
URL: https://github.com/apache/seatunnel/pull/7273#discussion_r1712635485


##########
seatunnel-connectors-v2/connector-kafka/src/main/java/org/apache/seatunnel/connectors/seatunnel/kafka/source/KafkaConsumerThread.java:
##########
@@ -58,8 +61,7 @@ public void run() {
                         task.accept(consumer);
                     }
                 } catch (Exception e) {
-                    throw new KafkaConnectorException(
-                            KafkaConnectorErrorCode.CONSUME_THREAD_RUN_ERROR, 
e);

Review Comment:
   The code of conduct is that if we encounter an exception, we terminate the 
job. If we do not encounter an exception, we do not terminate the job.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to