Carl-Zhou-CN commented on code in PR #9867:
URL: https://github.com/apache/seatunnel/pull/9867#discussion_r2375144893
##########
seatunnel-core/seatunnel-flink-starter/seatunnel-flink-starter-common/src/main/java/org/apache/seatunnel/core/starter/flink/execution/SinkExecuteProcessor.java:
##########
@@ -139,20 +152,20 @@ public List<DataStreamTableInfo>
execute(List<DataStreamTableInfo> upstreamDataS
((TableSinkFactory) (factory.orElse(null))));
sink.setJobContext(jobContext);
handleSaveMode(sink);
+
+ // check if sink supports schema evolution
+ if (sink instanceof SupportSchemaEvolutionSink) {
+ parallelism = 1;
+ sinkParallelism = true;
Review Comment:
What restrictions have caused this?
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SupportSchemaEvolutionSinkWriter.java:
##########
@@ -30,4 +32,48 @@ public interface SupportSchemaEvolutionSinkWriter {
* @throws IOException
*/
void applySchemaChange(SchemaChangeEvent event) throws IOException;
+
+ /**
+ * handle FlushEvent propagated from upstream
+ *
+ * @param event
+ * @throws IOException
+ */
+ default void handleFlushEvent(FlushEvent event) throws IOException {
Review Comment:
Do we have a way similar to zeta's approach?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
