CloverDew commented on code in PR #9867:
URL: https://github.com/apache/seatunnel/pull/9867#discussion_r2462552460
##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/sink/SupportSchemaEvolutionSinkWriter.java:
##########
@@ -30,4 +32,48 @@ public interface SupportSchemaEvolutionSinkWriter {
* @throws IOException
*/
void applySchemaChange(SchemaChangeEvent event) throws IOException;
+
+ /**
+ * handle FlushEvent propagated from upstream
+ *
+ * @param event
+ * @throws IOException
+ */
+ default void handleFlushEvent(FlushEvent event) throws IOException {
Review Comment:
@Hisoka-X Thank you for your valuable advice! I see that having the
Flink-specific code in the public API isn't ideal. This is indeed a problem
that needs to be fixed, and I'll create an issue
https://github.com/apache/seatunnel/issues/9980 to track it.
Here's my plan: refactor the proprietary processing logic into
`FlinkSinkWriter`, remove the implementation from the public API, and submit a
pull request with the fix as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
