PZh101 commented on PR #10961: URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-4585413376
Thanks for the detailed review! I believe this issue has been addressed in my latest commit. I've reverted the changes to MysqlDialect.java to keep the original MySQL runtime behavior intact. The Kingbase-specific fetch strategy is now fully isolated within its own dialect path. Could you please take another look when you have a moment? Thanks! The image below shows the comparison with my previous edits, and there are no differences anymore. <img width="2471" height="990" alt="image" src="https://github.com/user-attachments/assets/081f3523-49b8-49bc-b5f8-e9ecfc9a29f8"; /> The image below shows the diff on GitHub. I have already reverted the changes related to fetchSize in MysqlDialect. <img width="1505" height="335" alt="image" src="https://github.com/user-attachments/assets/a1e52385-7ef7-4aa6-8ec7-83eec2bd20ee"; /> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
