DanielLeens commented on PR #10961: URL: https://github.com/apache/seatunnel/pull/10961#issuecomment-4591810185
Thanks for double-checking this. I rechecked the commit list on the current PR branch before replying. Commit `80183ad9f5293e4fc53e8d240663635219413c1d` is indeed part of this PR history, but the current head is still `76c7c8524b86444261d75d2100209d0f0094b62c`, which is the same later revision I already reviewed on May 31. So this was not a stale-view issue on Daniel's side: the latest Daniel review already covered a head that includes `80183ad9...`. Because there still has not been a new commit after that latest Daniel review, I do not want to pretend a fresh full re-review happened on the same code version. The current Daniel blocker therefore remains the same as in the latest review: the PR still changes the real MySQL runtime fetch path in `MysqlDialect.creatPreparedStatement(...)`, and that behavior change still sits outside the Kingbase-only feature boundary. If you push a new commit that keeps the Kingbase-specific compatibility path but removes the unrelated MySQL runtime change, I will happily re-review the latest head again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
