DanielLeens commented on PR #11131: URL: https://github.com/apache/seatunnel/pull/11131#issuecomment-4763916290
Thanks for calling this out, @zhangshenghang — I rechecked the current head and I agree your concern is a useful one. My earlier approval was based on the production logic itself: the current `chunkIndex` scope does fix the cross-table round-robin bug I raised before. So from the runtime-behavior side, I do not see a new correctness regression on the same commit. That said, your testing point is fair: the current test would be stronger if it asserted the per-reader `rowStart` ordering directly, and even better if the regression guard exercised the production enumerator path rather than a copied loop shape. Since there is still no new commit on this PR, I’m treating this as a reply-only follow-up rather than opening a new full review round on the same revision. If @zhiliang-wu pushes a small test-only follow-up for the ordering assertion / production-path coverage, I’m happy to re-review the updated head. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
