zhiliang-wu commented on PR #11131:
URL: https://github.com/apache/seatunnel/pull/11131#issuecomment-4767135454
Thanks for the great feedback! You made excellent points regarding the
tests only verifying a copy of the logic
I've pushed a new commit to address these issues:
1. **Tests Now Drive Production Logic**: To fix this without requiring
mocked MaxCompute network sessions, I refactored
MaxcomputeSourceSplitEnumerator. The core chunking logic has been extracted out
of discoverySplits() into a package-private static method computeSplits(). All
unit tests now invoke MaxcomputeSourceSplitEnumerator.computeSplits(...)
directly, guaranteeing we are testing the actual production path.
2. **Added Ascending Order Regression Guard**: I've updated
MaxcomputeSourceSplitTest (specifically
testComputeSplitsAscendingRowStartOrder) to strictly assert that the splits
assigned to any given reader for any given table arrive in purely ascending
rowStart order. If someone accidentally swaps the LinkedHashSet back out for a
HashSet in the future, the test will immediately fail the build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
