davidzollo commented on PR #11099: URL: https://github.com/apache/seatunnel/pull/11099#issuecomment-4826121207
Thanks for the update, and thanks for tightening this carefully. I rechecked the latest head, and the two original source-level concerns are addressed now: - the default path restores the old fail-fast behavior for duplicate exact `table_path` rules unless `rule_match_mode` is explicitly configured - the chained schema-change path now stops propagation as soon as an inner transform returns `null` The focused regression coverage for these paths also looks aligned with the fix. So from my side, I don't have further source-level feedback on the original review topic. The remaining blockers before merge are the current PR state: - the PR is still dirty against `dev` - the latest `Build` check is still red Once those are cleared, this looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
