davidzollo commented on PR #11099: URL: https://github.com/apache/seatunnel/pull/11099#issuecomment-4826132697
> Thanks @davidzollo for your suggestions, updated the code to address them. > > The default path now keeps the old duplicate table_path fail-fast behavior unless rule_match_mode is explicitly configured. I also changed the chained map and flatMap helpers to stop schema-change propagation when an inner transform returns null. > > Added focused coverage for the chained schema-change path as well. > > Verified locally with the focused tests and the seatunnel-transforms-v2 package. > > Let me know if you have any more feedback. Thanks! Thanks for the update, and thanks for tightening this carefully. I rechecked the latest head, and the two original source-level concerns are addressed now: - the default path restores the old fail-fast behavior for duplicate exact `table_path` rules unless `rule_match_mode` is explicitly configured - the chained schema-change path now stops propagation as soon as an inner transform returns `null` The focused regression coverage for these paths also looks aligned with the fix. So from my side, I don't have further source-level feedback on the original review topic. The remaining blockers before merge are the current PR state: - the latest `Build` check is still red Once those are cleared, this looks good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
