dybyte opened a new pull request, #11244:
URL: https://github.com/apache/seatunnel/pull/11244

   ### Purpose of this pull request
   
   This PR excludes `engine_runningJobMetrics` from persistent IMAP storage.
   
   `engine_runningJobMetrics` stores high-frequency runtime metrics snapshots 
used for observability. Persisting this map through the generic `map.engine*` 
`map-store` configuration causes unnecessary WAL growth and write 
amplification, while providing limited recovery value compared with 
authoritative engine state.
   
   This change keeps the existing `map-store` behavior for other engine maps, 
but skips persistence initialization for the runtime metrics snapshot map.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes.
   
   When IMAP persistence is enabled through `map.engine*`, 
`engine_runningJobMetrics` is now intentionally excluded from persistent 
storage. This changes persistence behavior for runtime metrics snapshots and 
reduces WAL growth for observability-only state.
   
   The deployment documentation was also updated in both English and Chinese to 
clarify this behavior.
   
   ### How was this patch tested?
   
   - Added a unit test in `FileMapStoreTest` to verify that:
     - `engine_runningJobMetrics` skips persistent storage initialization
     - it does not fail even when the configured storage type is invalid
     - store/delete/load operations remain safe as no-op behavior
   
   ### Check list
   
   * [ ] If any new Jar binary package adding in your PR, please add License 
Notice according
     [New License 
Guide](https://github.com/apache/seatunnel/blob/dev/docs/en/developer/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new 
feature. https://github.com/apache/seatunnel/tree/dev/docs
   * [ ] If necessary, please update `incompatible-changes.md` to describe the 
incompatibility caused by this PR.
   * [ ] If you are contributing the connector code, please check that the 
following files are updated:
     1. Update 
[plugin-mapping.properties](https://github.com/apache/seatunnel/blob/dev/plugin-mapping.properties)
 and add new connector information in it
     2. Update the pom file of 
[seatunnel-dist](https://github.com/apache/seatunnel/blob/dev/seatunnel-dist/pom.xml)
     3. Add ci label in 
[label-scope-conf](https://github.com/apache/seatunnel/blob/dev/.github/workflows/labeler/label-scope-conf.yml)
     4. Add e2e testcase in 
[seatunnel-e2e](https://github.com/apache/seatunnel/tree/dev/seatunnel-e2e/seatunnel-connector-v2-e2e/)
     5. Update connector 
[plugin_config](https://github.com/apache/seatunnel/blob/dev/config/plugin_config)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to