DanielLeens commented on PR #11244: URL: https://github.com/apache/seatunnel/pull/11244#issuecomment-4899174986
Thanks for calling that out. I rechecked the recovery path before replying. On restart, `TaskExecutionContext.getOrCreateMetricsContext(...)` reads from `metricsSnapshotStore().getOrDefault(taskLocation, new SeaTunnelMetricsContext())`. With this PR, `engine_runningJobMetrics` is intentionally no longer persisted through `FileMapStore`, so after an engine restart the recovered task will recreate a fresh empty metrics context instead of restoring the previous runtime snapshot. From Daniel's side, that behavior is consistent with the current scope of this change: `engine_runningJobMetrics` is being treated as observability-only runtime snapshot state, not execution state needed for correctness or recovery. So I would not reopen this PR on that point. If SeaTunnel later wants metrics snapshots to survive restart as a first-class feature, that would need a separate design with explicit retention and recovery semantics rather than piggybacking on the current IMAP persistence path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
