DanielCarter-stack commented on code in PR #11246:
URL: https://github.com/apache/seatunnel/pull/11246#discussion_r3507071452


##########
docs/zh/connectors/sink/Rabbitmq.md:
##########
@@ -20,16 +20,20 @@ import ChangeLog from '../changelog/connector-rabbitmq.md';
 | host                       | string  | yes  | -     |
 | port                       | int     | yes  | -     |
 | virtual_host               | string  | yes  | -     |
-| username                   | string  | yes  | -     |
-| password                   | string  | yes  | -     |
+| username                   | string  | no   | -     |
+| password                   | string  | no   | -     |
 | queue_name                 | string  | yes  | -     |
 | url                        | string  | no   | -     |
+| routing_key                | string  | no   | -     |
+| exchange                   | string  | no   | -     |
 | network_recovery_interval  | int     | no   | -     |
 | topology_recovery_enabled  | boolean | no   | -     |
-| automatic_recovery_enabled | boolean | no   | -     |
-| use_correlation_id         | boolean | no   | false |
+| AUTOMATIC_RECOVERY_ENABLED | boolean | no   | -     |

Review Comment:
   Confirmed: this option name is intentionally uppercase. The connector code 
defines it as `Options.key("AUTOMATIC_RECOVERY_ENABLED")` in 
`RabbitmqBaseOptions`, so the documentation should keep the exact uppercase key 
to match the current user-facing config contract.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to