DanielLeens commented on code in PR #11246: URL: https://github.com/apache/seatunnel/pull/11246#discussion_r3507086041
########## docs/zh/connectors/sink/Rabbitmq.md: ########## @@ -20,16 +20,20 @@ import ChangeLog from '../changelog/connector-rabbitmq.md'; | host | string | yes | - | | port | int | yes | - | | virtual_host | string | yes | - | -| username | string | yes | - | -| password | string | yes | - | +| username | string | no | - | +| password | string | no | - | | queue_name | string | yes | - | | url | string | no | - | +| routing_key | string | no | - | +| exchange | string | no | - | | network_recovery_interval | int | no | - | | topology_recovery_enabled | boolean | no | - | -| automatic_recovery_enabled | boolean | no | - | -| use_correlation_id | boolean | no | false | +| AUTOMATIC_RECOVERY_ENABLED | boolean | no | - | Review Comment: Thanks for catching this. I checked the current connector contract again: the code path still defines the option key as `AUTOMATIC_RECOVERY_ENABLED` in `RabbitmqBaseOptions`, so the uppercase form here is intentional for now. That said, the docs are not fully consistent today because some of the other RabbitMQ pages still spell the same option in lowercase. So I agree this is worth aligning in the next update before we call the docs settled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
