davidzollo commented on PR #10521: URL: https://github.com/apache/seatunnel/pull/10521#issuecomment-4915291294
I pushed a follow-up commit to the PR branch to address the remaining `acceptsURL()` blocker on the current code path. What changed: - fixed `SingleStoreDialectFactory.acceptsURL()` so bracketed IPv6 hosts without an explicit port are no longer misparsed as an invalid port - kept numeric port validation when the port position is unambiguous - added regression coverage in both `SingleStoreDialectTest` and `JdbcDialectLoaderTest`, including loader coverage for `jdbc:singlestore://[2001:db8::1]/test` - adjusted the newer test assertions to the API/JUnit level that this branch actually compiles against Local verification: - `./mvnw -pl seatunnel-connectors-v2/connector-jdbc -Dtest=SingleStoreDialectTest,JdbcDialectLoaderTest -DfailIfNoTests=false -Dspotless.check.skip=true test` I also checked WhaleTunnel 2.6/3.0 locally while doing this pass and did not find a corresponding SingleStore dialect implementation there, so there is no same-issue follow-up to file on that side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
