DanielLeens commented on PR #10925: URL: https://github.com/apache/seatunnel/pull/10925#issuecomment-4968399562
Thanks @SEZ9 for the rereview. I would respectfully push back on treating this as a public API change. The touched signature is in `src/test/java` under the RocketMQ E2E suite, and the change only threads unique topic / consumer-group parameters through local test helpers to isolate runs. This is not a user-facing connector API or a stable SeaTunnel SPI surface. So from Daniel's side I would not reopen merge blockers on downstream compatibility for this test-only method change alone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
