DanielLeens commented on PR #11015:
URL: https://github.com/apache/seatunnel/pull/11015#issuecomment-4968423639
Rechecked the current head `a065e999a87a` against the latest `dev` after the
CI / merge-gate fact changed.
## Runtime path rechecked
```text
CDC schema change event
-> MultiTableSinkWriter.applySchemaChange(event)
-> subSinkErrorCheck()
-> hasSourceMatchedWriter(event)
-> ensureQueueWorkersSubmitted()
-> enqueueSchemaChangeBarrier(event)
-> enqueue one schema-change queue element into every worker queue
-> older queued rows drain first
-> SchemaChangeBarrier waits until all queue workers reach the
barrier
-> last arriving worker runs dispatchSchemaChangeToTargets(event)
-> collect source-matched writer
-> read
SupportSchemaEvolutionSinkWriter.getPhysicalSinkTableIdentifier()
-> add sibling writers with the same physical sink identifier
-> applySchemaChangeToTarget(...) for each target
-> release all parked queue workers
-> surface any schema-change failure through the existing
table-failure path
JDBC shared physical sink case
-> AbstractJdbcSinkWriter.applySchemaChange(event)
-> tableSchema = event.getChangeAfter().getTableSchema()
-> reOpenOutputFormat(event)
-> prepareCommit()
-> apply DDL against sinkTablePath
-> rebuild/open JdbcOutputFormat with the updated schema
MySQL multi-database parser case
-> MySqlSchemaChangeResolver.createDdlParser(...)
-> CustomMySqlAntlrDdlParser(dbzConfig)
-> parseQualifiedTableId(...) now resolves from the current
DDL/current database
-> same table name across different databases is no longer pinned
to the first table path
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side; sync latest `dev`
and rerun CI first
1. Blocking items
- None reopened from Daniel's source review on this unchanged head.
- This branch is behind upstream (`compare status: diverged`, `ahead_by=9`,
`behind_by=9`), and the current failing gate is `FAILURE gate: Build`:
https://github.com/apache/seatunnel/runs/86601189863
2. Lowest-cost next step
- Please sync with the latest `dev` and rerun the failing gate first.
- If it still fails on the updated head, I can help narrow down the new
failure from there.
Daniel only has `READ` permission on this repository, so a write-capable
maintainer may still need to handle the final approval / dismissal step once
the gate is clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
