DanielLeens commented on PR #11015: URL: https://github.com/apache/seatunnel/pull/11015#issuecomment-5021860404
Thanks @SEZ9 for taking another look. I rechecked the two compatibility warnings against the exact unchanged head, but they do not describe public API removals: - `MultiTableSinkWriterTest.java` is test code; its test/helper signatures are not a downstream connector API. - `CustomMySqlAntlrDdlParser` keeps the original two-argument constructor as a deprecated compatibility overload and delegates to the new constructor, so source and binary call sites remain available. The real blocker on this head remains the barrier-enqueue/worker-exit lost-notification window from my latest self-review. This follow-up only disposes the new external findings; it does not clear that existing blocker or act as an independent approval for my own PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
