DanielLeens commented on PR #11198:
URL: https://github.com/apache/seatunnel/pull/11198#issuecomment-4968425597
Rechecked the same unchanged head `dfac80dfa4b9` after the CI / merge-gate
fact changed.
## Runtime path rechecked
```text
Job config with sink { Couchbase { ... } }
-> CouchbaseSinkFactory.optionRule()
-> requires connection.string / username / password / bucket /
collection
-> optional scope / flush / retry / upsert / primary-key
-> CouchbaseSinkFactory.createSink(context)
-> validates upsert-enable requires primary-key
-> builds CouchbaseWriterOptions
-> stamps CatalogTable identifier as Couchbase bucket/collection
-> CouchbaseSink.createWriter(context)
-> CouchbaseWriter(options, catalogTable, context)
-> validates configured primary-key fields exist in
SeaTunnelRowType
-> Cluster.connect(...), waitUntilReady(bucket),
scope(...).collection(...)
-> CouchbaseWriter.write(row)
-> skips UPDATE_BEFORE, rejects DELETE explicitly
-> converts SeaTunnelRow fields to JsonObject
-> builds stable document key from primary-key, or UUID when no key is
configured
-> buffers and flushes on size / timer / prepareCommit / close
-> doFlush()
-> materializes stable (docId, doc) units before retry
-> insert/upsert with retry cursor and ambiguous-timeout handling
-> clears buffer only after full success
```
## Merge conclusion
### Conclusion: source blocker cleared from Daniel's side; waiting for the
current gate
1. Blocking items
- None from Daniel's source review on this unchanged head.
2. Current gate
- The current remaining gate is still pending: `PENDING gate: Build`
(https://github.com/apache/seatunnel/runs/86998960454)
- Daniel only has `READ` permission on this repository, so a write-capable
maintainer may still need to handle the final approval / dismissal step once
the gate is clear.
I do not see a reopened code-side blocker from Daniel on the current head.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
