DanielLeens commented on PR #11750: URL: https://github.com/apache/seatunnel/pull/11750#issuecomment-5248808844
You're welcome — and thanks for taking the pushback well and turning it into a genuinely better fix rather than a defensive patch. The suppressed-exception distinction is easy to gloss over in a nested `try/finally`, so I appreciate that you re-ran the three new cases against the pre-fix commit to confirm they actually fail there rather than just passing trivially against the final version. Agreed on the helper duplication too — following the existing Pulsar precedent is the right call here, and extracting a shared utility with only two data points (Pulsar + Neo4j) would be premature abstraction. Worth revisiting if a third connector ends up wanting the same close-and-collect shape. The review is already in as Approved with no blockers, so this is ready to merge from my side. Thanks again for the careful fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
