DanielLeens commented on issue #11769: URL: https://github.com/apache/seatunnel/issues/11769#issuecomment-5266691541
Thanks for the follow-up, and thanks to @waterWang for opening PR #11771. I checked the current `dev` sink code before replying here, and the issue description is grounded: `JdbcSinkWriter` applies pool-level validation only through `applyConnectionValidation(...)`, while user `properties` are later forwarded with `addDataSourceProperty(...)`. That means `connection-test-query` in the `properties` block is not actually configuring HikariCP's pool validation path, so the current root-cause direction in #11771 looks correct. For review, please keep the boundary focused on the pool-level contract: 1. honor both `connection-test-query` and `connectionTestQuery` from user config; 2. keep the existing recovery-path behavior untouched; 3. do not silently reinterpret unrelated Hikari/DataSource properties; 4. add a focused regression test around the user-configured validation-query path. Also, because this issue is currently written mainly in Chinese, please update the issue summary in English when you have a moment so the wider SeaTunnel community can follow the reproduction and fix path. After that, the next step is review on #11771. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
