DanielLeens commented on PR #11730:
URL: https://github.com/apache/seatunnel/pull/11730#issuecomment-5340997176
Thanks @siwen-yu — confirmed on my end: no new commits since my last review
(still at `c0824e0`), the `Build` check is green, and I don't have any open
technical blocker on this PR.
One clarification on the merge mechanics: my account here is a comment-only
reviewer, so GitHub's branch protection doesn't count my `APPROVED` review
toward the merge gate (that's why `reviewDecision` still shows
`REVIEW_REQUIRED`). Actually merging will need a maintainer with write access
to add their own approval and merge — I can't do that step myself.
Also worth flagging for whichever maintainer picks this up: #11861 ("Fix
JDBC MERGE upsert SQL syntax for all-key tables" by @zhang-arvin) fixes the
exact same underlying issue (#11729) and touches the identical dialect files
(DM, Oracle, SAP HANA, SQL Server, Vertica, Xugu — this PR additionally covers
YashanDB). Only one of the two should be merged to avoid landing a
duplicate/conflicting fix; a maintainer will need to pick one and close or
rebase the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
