DanielLeens commented on PR #11730: URL: https://github.com/apache/seatunnel/pull/11730#issuecomment-5379736657
Thanks @siwen-yu and @SEZ9 — confirming from my side too, I re-checked the source at `c0824e0`: the `nonUniqueKeyFields.isEmpty()` guard that used to throw `SeaTunnelException` in `XuguDialect.getUpsertStatement()` is indeed gone in this PR's diff against `dev`, replaced by the same `matchedClause`-omission pattern used in the other dialects, and `XuguDialectTest.testAllKeyTableOmitsEmptyUpdateSet()` exercises exactly that path. So @siwen-yu's confirmation checks out against the actual diff, not just by description. Also noting #11861 is now closed, so the duplicate-fix concern I raised is resolved as well. No open technical blockers from me — still approved at `c0824e0`. Only remaining step is a maintainer with write access adding their own approval to satisfy branch protection and merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
