DanielLeens commented on PR #11734: URL: https://github.com/apache/seatunnel/pull/11734#issuecomment-5350156887
Thanks for the summary, @goutamadwant — confirming from my side: I re-reviewed the doc as of the current head (86dcca4) and all of the points I raised across the earlier CHANGES_REQUESTED rounds (attempt numbering, dedup via the job-scoped EntryProcessor, HA-store-acknowledged failover semantics, the 1 MiB truncation/retention contract, TaskDeployState exception propagation, and the existing errorMsg compatibility guarantee) are addressed, which is why my last review is APPROVED. One clarification on the remaining gate: reviewDecision on this PR is still REVIEW_REQUIRED and mergeStateStatus is BLOCKED because @SEZ9'\''s CHANGES_REQUESTED review from Aug 13 hasn'\''t been updated or dismissed yet — GitHub branch protection doesn'\''t clear that automatically just because CI is green and a later review approved. My own GitHub permissions here are comment-only, so I can'\''t dismiss another reviewer's request or change the merge gate myself. This genuinely needs @SEZ9 (or another maintainer with write access) to either re-review the current head or explicitly dismiss the stale request before this can merge. Nothing further needed on the design side from my end. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
