SEZ9 commented on PR #11837: URL: https://github.com/apache/seatunnel/pull/11837#issuecomment-5366245211
Thanks everyone for the thorough follow-through on this one. @DanielLeens — appreciate the deep re-verification. Your notes confirm that the current head `83403fce36c5` is content-identical to the previously verified `e803a00679f` (rebase-only SHA change), that all five reported problems in the comment-DDL path are covered (table identifier normalization, the VARCHAR length canonicalization fallback for comment-only detection, the deprecated Zeta dispatcher handling, the Databend nested column-comment dispatch with its dedicated regression test, and the DDL walk error swallowing), and that the `Build` check for this exact head completed with SUCCESS. With your approval and @davidzollo's earlier approval, there are no outstanding review blockers. @CloverDew — thanks for the patience across four rounds of iteration. Two small asks before merge: 1. Please don't push any new commits to this branch — the passing CI result is tied to `83403fce36c5`, and any new head would require a fresh run. 2. Per @DanielLeens's note, the branch has diverged from `dev` (ahead_by=3, behind_by=12 at his last check). I agree with him that this is queue metadata rather than a blocker given the directly-evaluable green result on the current head, so no rebase is needed unless a merge conflict surfaces — if one does, please sync and ping us. Assuming the head stays put, this is ready to merge from my side. Thanks again for the contribution! <!-- streview-comment:425 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
