SEZ9 commented on PR #11564: URL: https://github.com/apache/seatunnel/pull/11564#issuecomment-5366243678
Thanks @DanielLeens for the thorough re-verification, and @nzw921rx for the earlier approval. Summarizing where we stand on the offload change: - The source at head `e01712f9` is confirmed byte-for-byte identical to the previously approved heads (`2553537c465f`, `e22ffca5e440`) for the two files in the diff, with the only new commit being the merge from `dev` that doesn't touch `ReportMetricsOperation.java` or `ReportMetricsOperationTest.java`. So there's no new logic to review — the `Offload` / `OFFLOADABLE_EXECUTOR` direction remains approved from the source side. - On the CI status you flagged: given the failing jobs (`unit-test (11, windows-latest)`, `engine-v2-it (8, ubuntu-latest)`, `all-connectors-it-7 (11, ubuntu-latest)`, `doris-connector-it (8, ubuntu-latest)`) don't intersect the metrics-offload call path and the same diff passed CI twice before, I agree this reads as unrelated flakiness rather than a regression here. That said, we shouldn't merge on a red `Build`. Concrete remaining asks before merge: 1. Please re-run just the failed jobs on `e01712f9` as suggested (`gh run rerun <run-id> --failed`) and report back once the `Build` check is green. 2. Please file the short follow-up issue for the `shouldKeepRemoteGenericOperationsResponsiveWhileMetricsWaitForOffloadExecutor` timing-centralization note so the Low-severity non-blocking item is tracked post-merge — either of you opening it works for me. Once CI is green on the current head, this is good to go from my side. Thanks both! <!-- streview-comment:422 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
