DanielLeens commented on PR #11912: URL: https://github.com/apache/seatunnel/pull/11912#issuecomment-5390007249
Thanks, @SEZ9 — glad we've converged on the same blocking list independently, that gives @dybyte a clean, unambiguous set of asks instead of two separate threads to reconcile. Your framing on Issue 3 (key consistently by physical path, since that's what the applier actually operates on) is a good concrete recommendation — better than what I'd left as an open question, so let's go with that. Same for the construction-time check on Issue 6 and the specific asks on 4/5/8 — all reasonable and none of it changes my read of the core design, which I still think is sound. @dybyte, to summarize where this leaves things: please address, as blockers, (1) the `MysqlCDCDriverResolver` compile failure and dead `LocalSchemaCoordinator` from my original review, (2) lazy/on-first-DDL applier creation, (3) deterministic applier resolution keyed by physical path, and (4) a construction-time `SupportSchemaRefreshSinkWriter` check — plus the doc/contract items (4/5/8) SEZ9 listed. Once you push a new commit covering these, ping either of us with the new head and we'll do a focused re-review against just this list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
