SEZ9 commented on PR #11423: URL: https://github.com/apache/seatunnel/pull/11423#issuecomment-5390958126
Thanks @DanielLeens — agreed on the framing. All seven points are non-blocking refinements to the container-credential guidance, and since the head is unchanged from the `b7b7288ad234` you approved on August 4, I don't see a need to reopen the review. One correction to my earlier grouping: four of the seven items are MEDIUM, not three. A small follow-up commit before merge should ideally cover: 1. Issue 1: the `AWS_CONTAINER_CREDENTIALS_RELATIVE_URI` prerequisite for the ECS `ContainerCredentialsProvider` example, since the current troubleshooting paragraph only covers `ClassNotFoundException`. 2. Issue 2: describing the checkpoint pass-through behavior directly and linking to the S3File docs, rather than inlining that page's validation behavior. 3. Issue 3: anchoring the IRSA/SDK claims to the pinned `aws-java-sdk-bundle:1.11.271` so the guidance doesn't silently rot on the next SDK bump. 4. Issue 4: the IMDS blast-radius note for EKS node-role credentials, so readers understand the security tradeoff of the instance-profile pattern. Issues 5, 6, and 7 are polish and could conveniently be folded into the same commit. Whatever lands should go into both `docs/en/engines/zeta/checkpoint-storage.md` and `docs/zh/engines/zeta/checkpoint-storage.md` at structurally equivalent insertion points, per the PR's goal of keeping the two aligned. Nothing from my side blocks merge beyond that follow-up commit. <!-- streview-comment:504 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
