SEZ9 commented on PR #11487: URL: https://github.com/apache/seatunnel/pull/11487#issuecomment-5390958885
Thanks @DanielLeens — glad we're aligned on the merge direction, and I agree with your read: nothing in this doc-level round changes the source-level picture on `31c1e0ed`, so this stays "can merge" pending the documentation fixes. To answer your comment directly: nothing new has landed since `31c1e0ed`, so all of the doc items are still open. Concretely, what I'm asking for in the next commit: 1. **Option-row restrictions (MEDIUM):** carry the snapshot-only incompatibility on the affected option rows themselves (`stop.mode`, `startup.specific-offset.*`, `startup.timestamp`) in `docs/en/connectors/source/MySQL-CDC.md`, not only in the `startup.mode` cell and the prose section — this also covers the restore-with-changed-`startup.mode` edge case you called out. 2. **Consistency semantics (MEDIUM):** document what snapshot-only with `exactly_once = false` guarantees (or doesn't) under concurrent writes. 3. **Fail-fast note (MEDIUM):** the server-id/parallelism mismatch under snapshot-only + exactly_once is currently only surfaced by MySQL at runtime; at minimum the docs should state this clearly. 4. **Smaller doc items (LOW):** ZH parity for the `exactly_once` row and FAQ updates; replace literal credentials in the new example; correct the inaccurate "rejected by MySQL" claim about a shared `server-id`; make the snapshot-only example consistent with the preceding paragraph (it sets a server-id range but not `exactly_once`); and restore the precision of the binlog-resume position wording in the reworded FAQ answer for initial mode. Once an updated commit lands with these, I'll re-verify the doc changes and, together with your standing pass, we should be good to merge. Happy to clarify wording suggestions on any of the above if helpful. <!-- streview-comment:507 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
