DanielLeens commented on PR #11718: URL: https://github.com/apache/seatunnel/pull/11718#issuecomment-5412486987
Thanks for the clear breakdown, @SEZ9 - that scoping for Items 1/2/6 matches what we converged on. I confirmed the head is still `d73c2b90bf` (unchanged since my last approval), so there's nothing to re-review yet. Once the follow-up commit lands, I'll do a focused pass on the in-container-kill piece specifically, as agreed - checking that it doesn't reintroduce any blocking behavior on the timeout path and that it plays correctly with the existing `runningCount`/thread-leak-check interaction already documented in this class. The two documentation fixes (Items 2 and 6) should be straightforward to verify against the actual call sites and bytecode claims, same as the rest of this review's findings. No blockers on the current head - it remains approved and mergeable as-is. Ping this thread when the commit is up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
