nzw921rx commented on PR #11987:
URL: https://github.com/apache/seatunnel/pull/11987#issuecomment-5437532721
```java
private static int getSplitOwner(String splitId, int numReaders) {
return (splitId.hashCode() & Integer.MAX_VALUE) % numReaders;
return HashUtils.nonNegativeMod(splitId.hashCode(), numReaders);
}
```
I’d like to use this as an example. I don’t see a clear readability
improvement here; instead, I need to navigate into a new utility method to
understand the underlying logic.
For a relatively simple hash calculation like this, I’m not sure that
additional abstraction is necessary. I’d like to discuss this point with you
and would appreciate your thoughts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
