Nikk8091 opened a new pull request, #12004:
URL: https://github.com/apache/seatunnel/pull/12004

   ### Purpose of this pull request
   
   This PR handles the `connector-activemq` portion of #11007.
   
   It completes the ActiveMQ sink factory's declarative `OptionRule` validation 
by:
   
   - rejecting blank `uri` and `queue_name` values;
   - rejecting a blank supplied `client_id`;
   - adding the supported `consumer_expiry_check_enabled` option to the factory 
rule.
   
   The change remains limited to declarative configuration eligibility. Broker, 
network, and runtime checks remain imperative.
   
   ### Does this PR introduce any user-facing change?
   
   Yes.
   
   Invalid blank `uri`, `queue_name`, and supplied `client_id` values are now 
rejected during configuration validation. The supported 
`consumer_expiry_check_enabled` option is now accepted by unknown-key 
validation.
   
   ### How was this patch tested?
   
   - Added positive and negative factory validation tests.
   - `ActivemqFactoryTest`: 6 tests passed, 0 failures.
   - Complete ActiveMQ module `verify`: passed.
   - Repository-wide Spotless formatting: passed.
   
   ### Check list
   
   - [x] No new binary dependency was added.
   - [x] No connector registration or distribution changes are required.
   - [x] No incompatible configuration name or default was introduced.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to