DanielLeens commented on PR #12005: URL: https://github.com/apache/seatunnel/pull/12005#issuecomment-5470020721
Addressed the review feedback in 975999036e. - Restored the existing rejection behavior for dialects without validated range support; fallback now applies only after an opt-in dialect's validation fails. - Preserved third-party compatibility with a backward-compatible default reader-session decision, while MySQL/Oracle subclasses now fail closed consistently in capability, planning, and reader paths. - Hardened Oracle validation with physical-table checks, session NLS checks on each reader, data-bound column-collation validation, and an exact printable-ASCII encoding check that rejects EBCDIC ordering without a fragile charset allow-list. - Redacted sampled values from validation reasons, wrapped explicit-range SQL validation failures with context, documented reader-session behavior, and added focused regression coverage. The previous Build failure was an unrelated task-status race (); its rerun was cancelled when this new head triggered a fresh Build. The current Build is pending on this commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
