SEZ9 commented on issue #12010:
URL: https://github.com/apache/seatunnel/issues/12010#issuecomment-5476203761

   Confirmed by code inspection: PeekBlockingQueue.put catches 
InterruptedException without restoring the interrupt flag or propagating the 
failure, so submitJob proceeds to complete jobSubmitFuture successfully. 
Suggested fix: restore the interrupt status 
(Thread.currentThread().interrupt()) and either rethrow InterruptedException or 
wrap it so CoordinatorService can complete jobSubmitFuture exceptionally 
instead of reporting success.
   
   The same swallow-and-continue pattern in PeekBlockingQueue may affect other 
callers (e.g., take/peek paths) — worth auditing all interruptible operations 
in that class while fixing this.
   
   A regression test could interrupt the submitting thread around 
pendingJobQueue.put and assert that the submission future completes 
exceptionally and the physical plan is not moved to PENDING. Would you be 
willing to open a PR with the fix and test?
   
   <!-- streview-comment:692 -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to