DanielLeens commented on PR #11746: URL: https://github.com/apache/seatunnel/pull/11746#issuecomment-5480371114
Thanks, @SEZ9 — appreciate you picking this up for merge. One live-CI note for whoever pulls the trigger: the apache-side `Build` check currently shows as `cancelled`/failed, but that's the known fork-run-pointer artifact, not a real failure on this head. The actual fork run (`li3zhi4/seatunnel` run `33202704220`, head `0241617929f`) has every job this PR's diff can affect green — `updated-modules-integration-test-part-2 (8, ubuntu-latest)` and `(11, ubuntu-latest)` (the shards running `JdbcMysqlSplitIT#testCompositeKeyWithStringColumn` and `JdbcOracleSplitIT`), `unit-test`, and `Code style` all `success`. The only red job left is `doris-connector-it (11)`, which is the pre-existing `DorisErrorIT.testDoris:78` assertion failure in `connector-doris-e2e` — a module this diff never touches — already confirmed unrelated above. No outstanding code concerns from my side either. Thanks again for the thorough follow-through on this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
