DanielLeens commented on PR #12033: URL: https://github.com/apache/seatunnel/pull/12033#issuecomment-5522158259
Thanks @nzw921rx for flagging this. Confirming from the API: `mergeStateStatus` is currently `DIRTY` and `mergeable` is `CONFLICTING` against `dev`, so @davidzollo this branch does need to sync with `dev` and resolve the conflicts before it can be merged. To be clear on the review side: nothing in my earlier review is blocking (Conclusion: Ready to merge, with two non-blocking follow-ups noted). Once the conflicts are resolved and CI stays green on the rebased head, this is good to go from my end -- no need for a fresh full review unless the conflict resolution ends up touching more than the new test file itself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
