DanielLeens commented on PR #11496:
URL: https://github.com/apache/seatunnel/pull/11496#issuecomment-5541828141
Thanks for the update, and for taking the extra time to get the JSON/array
default-value handling right rather than pushing out a partial fix — that's the
right call given how many edge cases surfaced across these rounds.
To save you a round-trip once you're back from Draft, here's the confirmed
blocker list to make sure the next commit covers, combining both review threads:
1. `ParameterSplitter` unbalanced-delimiter validation (removed, needs
restoring)
2. `Collectors.toMap` duplicate-key crash on a repeated `-i` key
3. `insideQuotes` in `ParameterSplitter` can get stuck `true` when a closing
quote isn't immediately delimiter-adjacent
4. The bracket-excluding default-value regex in `PlaceholderUtils`
(`${key:[a,b]}` doesn't resolve)
Plus the Assert-sink `field_type` mismatch (`string` vs actual `bigint`) you
already flagged in `jdbc_mysql_json_params.conf`.
Ping me once it's back out of Draft with a new commit and I'll do a fresh
full pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
