DanielLeens commented on PR #11814: URL: https://github.com/apache/seatunnel/pull/11814#issuecomment-5577170135
Thanks for digging into this, @goutamadwant — that's a useful data point. If both `engine-v2-it (8)` and `engine-v2-it (11)` are stalling during worker registration/coordinator init and never getting as far as the `JobEventHttpReportHandler` HTTP assertions, that does point away from a defect in this PR's own `JobEventHttpReportHandlerTest` logic and toward either (a) a genuine startup-timing regression somewhere in the bootstrap path this PR's `okhttp3` migration touches indirectly (e.g. classloading/dependency shading order affecting cluster join), or (b) an environment/resource-contention issue on the runner that's unrelated to the diff — but I agree with you that we can't respectably call it either one without a thread dump. Guessing at this point (e.g. bumping a timeout again) would just mask the real failure mode if it recurs after merge. Your next step — an isolated HTTP-enabled vs. HTTP-disabled startup run with a dump captured before teardown — is exactly the right way to isolate whether this is specific to the `okhttp3` client initialization holding up worker registration, or a pre-existing flake in the coordinator bootstrap that would reproduce with or without your change. Please share the dump (or a link to the run) once you have it either way. No new commit has landed since my last full review (head is still `dfda45aef`), so I'm not re-reviewing the code again in this comment — my prior conclusions on `JobEventHttpReportHandler.java` and its test stand as posted. I'll hold off on any merge-readiness call until we know whether this `engine-v2-it` failure is diff-related; once you've got the isolated dump, or once a fix/adjustment actually lands, ping me and I'll take it from there — a full re-review if there's a new commit, or a direct answer on the CI question if it's just new evidence. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
