Rangsh commented on PR #12173: URL: https://github.com/apache/seatunnel/pull/12173#issuecomment-5577498638
Thanks @DanielLeens for the thorough review and for confirming the fixture / production root causes. I addressed the two non-blocking documentation notes in 991e67b: 1. Added a caller-side serialization note on `storeFinishedPipelineMetrics` (points to `JobMaster#metricsLock`). 2. Added short Javadoc on the growth-fixture helpers (`cleanPreviousGrowthPhase`, `verifyLastRunningJobResident`, `verifyLastCompletedJobResident`, `verifyLastGrowthPhaseDurability`). Also noted — the trial tear-down cleanup of the last growth batch was intentional fixture hygiene. Please take another look when you have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
