SEZ9 commented on PR #11512:
URL: https://github.com/apache/seatunnel/pull/11512#issuecomment-5629220931
Thanks for the detailed walk-through of
`CoordinatorService.collectCdcEnumeratorProgress()` and the "Runtime
collection" section of `docs/en/developer/cdc-progress.md`.
**F4** – I appreciate the explanation, but I can only close a finding
against the actual changed content, not a description of it. Could you point me
to where in this PR's diff (at `b921264bb`) the coordinator collection path and
the corresponding doc text are visible? If the doc section was updated in this
PR to match the coordinator-derived request model, a pointer to that hunk is
all I need to mark F4 resolved.
**F8** – your comment appears to have been cut off mid-sentence ("Yes, the
deep-immutability guarantee holds at ..."). Could you post the rest?
Specifically, how are `CdcSnapshotSplitProgress` elements made immutable so
that the "immutable per-split details" claim in `CdcEnumeratorProgressReport`
doesn't rest solely on the shallow copy?
Still open from the previous review:
- **F1** – bounding `activeSplits` in `CdcEnumeratorProgressReport`, or
dropping the "bounded" wording from the contract.
- **F2** – an explicit statement in `docs/en/developer/cdc-progress.md` that
connector-native position payloads must not carry credentials or connection
secrets.
- **F3** – confirming the engine codec encodes `CdcProgressAccuracy` (and
the other new enums) by name rather than ordinal.
- **F5** – listing which connectors currently implement the progress
provider in the developer doc.
- **F6** – aligning the `CdcProgressLifecycle.SNAPSHOT` Javadoc with the
ownership rule in the doc.
- **F7** – basic invariant validation on the count fields (non-negative,
mutually consistent).
Happy to take another pass once these are addressed or answered.
<!-- streview-comment:961 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
