SEZ9 commented on PR #12218: URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-5650142244
@Rangsh Thanks for the mapping — that closes the both-sides checklist item for me: - Callback side (`onContextPublished`) → `testDeployLocalTaskRollsBackAfterPostPublishFailureAndAllowsRedeploy` - Submission side (`submitBlockingTask` / `RejectedExecutionException` after partial submit) → `testDeployLocalTaskRollsBackAfterPartialBlockingSubmitRejection` The key point is that both redeploy assertions go through `deployTask(Data)` rather than `deployLocalTask`, so they exercise the `executionContexts.containsKey` skip branch instead of bypassing it. Nothing further from me on the code side for head `fee6db3b3c`. One remaining ask before merge: the fork run for this head (`34558932185`) finished with a failure — `transform-v2-it-part-1 (11)` and `all-connectors-it-2 (8)` failed and `paimon-connector-it (11)` was cancelled. None of those areas are touched by this diff, so I don't expect this change caused them, but I'd like the CI item closed out properly rather than left as "unrelated by inspection." Could you rerun those jobs on the current head and post the result, or, if they fail again, link the failure logs so we can confirm they're pre-existing flakes? Once that's in, this is good to go from my side. <!-- streview-comment:999 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
