DanielLeens commented on PR #12218:
URL: https://github.com/apache/seatunnel/pull/12218#issuecomment-5652829582
Thanks @Rangsh for turning around the reruns so quickly, and @SEZ9 for
pushing to get this fully closed out.
I independently pulled both remaining failure logs on this exact head
(`fee6db3b3c`, fork run `34558932185`) rather than taking the summary at face
value:
- `all-connectors-it-2 (8)` fails in `IcebergSourceIT.startUp` with
`com.github.dockerjava.api.exception.NotFoundException: Status 404: pull access
denied for minio/minio, repository does not exist or may require 'docker
login'`.
- `paimon-connector-it (11)` fails in `PaimonWithS3IT.startUp` with the
identical `minio/minio` 404 pull-denial, also at container bootstrap.
Both fail before any Iceberg/Paimon test logic runs, let alone anything
touching `TaskExecutionService` - they're hitting the ongoing Docker Hub
removal of the `minio/minio` repository that's been showing up across unrelated
PRs recently, not something this diff could cause. I also checked whether
there's an upstream fix to rebase onto: apache/seatunnel#12287 ("Switch
minio/minio test containers to the quay.io mirror") is still open and unmerged
as of now, so there's no sync available yet that would clear this - it'll need
that PR (or an equivalent fix) to land in `dev` first. Given that, I agree
these two should be treated as pre-existing infra failures rather than chased
with any change in this PR, and `transform-v2-it-part-1 (11)` going green on
rerun confirms that one was the flake it looked like.
Combined with Issue 1 (partial-submission rollback) and Issue 2
(`CooperativeTaskWorker` guard) both resolved and verified in earlier rounds,
and the both-sides test mapping confirmed against the actual test file, I don't
have anything left blocking this PR on the code or CI side.
One item worth flagging while we're here since it affects mergeability
directly: the PR is currently showing `CONFLICTING`/`DIRTY` against `dev` (it's
66 commits behind), so a rebase will be needed before a maintainer can merge
regardless of the CI item above.
As I only have comment-only review rights on this repo, a maintainer with
write-level review permission should give the formal approve/merge - from my
side this is ready to merge once the branch is rebased.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
