nzw921rx commented on code in PR #12307: URL: https://github.com/apache/seatunnel/pull/12307#discussion_r4003304646
########## tools/benchmarks/suites/benchmarks_core.txt: ########## @@ -14,20 +14,11 @@ # limitations under the License. # Fundamental data-path operations. -SeaTunnelRowBenchmark -IntermediateQueueBenchmark -DebeziumJsonFormatBenchmark SeaTunnelPipelineBenchmark.sourceSink$ SeaTunnelPipelineBenchmark.sourceTransformSink$ +SeaTunnelPipelineBenchmark.sourceTransformSinkWithObservabilityAndTrace$ # Checkpoint coordination and storage. CheckpointingTimeBenchmark.checkpointSingleInput$ -CheckpointStorageBenchmark.checkpointPersistenceTransaction$ - -# High-frequency IMap state paths. -IMapJobStorageBenchmark.taskGroupStateTransition$ -IMapJobStorageBenchmark.runningMetricsReport$ - -# DAG persistence and reload. -IMapDagStorageBenchmark.finishedJobDagStore$ -IMapDagStorageBenchmark.finishedJobDagLoad$ +CheckpointStorageBenchmark.checkpointIdAtomicIncrement$ +CheckpointStorageBenchmark.checkpointOverviewIncrementalUpdate$ Review Comment: What you said makes sense. Currently, we are not afraid of exposing problems, but it is difficult for me to decide whether our daily core suite needs these two in the future. Therefore, I prefer to remove them and keep the core suite concise, making recognition and regression easier to avoid noise pollution -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
