SEZ9 commented on PR #12014:
URL: https://github.com/apache/seatunnel/pull/12014#issuecomment-5674357495
Thanks for the update on this PR. The automated follow-up notes that the
Build run on `d7c1ea8958eb` has completed green and that the PR currently has a
merge conflict with the latest `dev`. Before I take a final merge action, I
still need to close out my previous review findings, since I don't see
responses to them in the thread yet:
- **PR12014-F1 (HIGH)** – Flush-then-TRUNCATE on the JDBC sink is not
failure-atomic (TRUNCATE is DDL with an implicit commit, can fail on FK
constraints, and behavior under exactly-once/XA mode is undefined). Please
describe how this is handled, or document it as an explicit limitation.
- **PR12014-F2** – Enabling table-operations force-opens Debezium
`include.schema.changes`, so unrelated DDL is routed through the new
deserializer paths. Please confirm whether unrelated DDL is safely ignored.
- **PR12014-F3** – The TRUNCATE statement built from DDL-parsed table names
must go through dialect identifier quoting. Please confirm this is done.
- **PR12014-F4** – The documented at-least-once restore semantics (flush →
truncate → checkpoint replay) still need a restore/failover test.
- **PR12014-F5 / F7** – Flink/Spark and non-JDBC sinks should be rejected at
job submission rather than failing at the first TRUNCATE, and `Jdbc.md` ("do
not apply") and `MySQL-CDC.md` ("fail fast") need to agree on the actual
behavior.
- **PR12014-F6** – The new `EventType` constant is inserted mid-enum and
shifts the ordinals of the `LIFECYCLE_*` values; please append it at the end.
- **PR12014-F8** – The `table-operations.include/exclude` option rows should
link to the "Table operation events" section, matching the schema-changes rows.
Concrete asks:
1. Rebase onto the latest `dev` and resolve the conflicts.
2. For each finding above, either point me to where it's addressed in the
current head or push the fix.
Once those are in, I'll do a final pass and merge.
<!-- streview-comment:1066 -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
