SEZ9 commented on PR #12014: URL: https://github.com/apache/seatunnel/pull/12014#issuecomment-5755215166
Thanks for merging `origin/dev` in `913cc45e` to clear the conflicts. Since that commit landed after the approval on `d7c1ea8958eb`, I'm treating this as a full re-review of the current head rather than relying on the earlier conclusions. I'll verify the previously raised points directly against the diff — the flush-then-`TRUNCATE` flow on the JDBC sink and its interaction with exactly-once mode, how unrelated DDL is routed when `table-operations` is enabled, identifier quoting in the sink-side `TRUNCATE TABLE`, restore/failover test coverage for the truncate path, the placement of the new `EventType` constant, Flink/Spark behavior and the consistency of the Jdbc and MySQL-CDC docs, and the option-table links for `table-operations.include/exclude` — and post the outcome here. No action needed on your side in the meantime. <!-- streview-comment:1214 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
