saloni-eng commented on PR #12281: URL: https://github.com/apache/seatunnel/pull/12281#issuecomment-5687242966
Hi @DanielLeens , I’ve addressed all the review feedback from the fifth round. Here is a summary of the fixes implemented: Issue 3 (Blocker — Test): Added a real behavioral test (testFailsFastWhenResponseExceedsMaxSize) using MockWebServer to verify the fail-fast exception path and ensure HttpConnectorException is correctly thrown when response sizes exceed limits. Issue 2 (Blocker — Default & Documentation): Adjusted the default threshold for max_response_size_bytes to 20MB (20971520 bytes) and added a dedicated Large Exports & Memory Considerations section in the documentation detailing the heap sizing requirements. Issue 4 (Non-blocking — Naming): Ensured the documentation file is properly aligned with connector conventions (Splunk.md). As previously agreed, the broader streaming HttpClientProvider optimisation that we identified with @goutamadwant, and connector-family E2E tests are left out of scope for this PR, but remain worth tracking as future follow-ups! Please have a look whenever you have a spare moment. Thank you! Saloni -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
