SEZ9 commented on PR #11307: URL: https://github.com/apache/seatunnel/pull/11307#issuecomment-5707486093
@goutamadwant Thanks for checking — knowing `testFilterRowKindMultiTable` failed against the Flink 1.15.3 / 1.18.0 containers rather than Spark 3.5.8 in run `34918482860` takes it out of the "regression from this PR" bucket, so it can be handled separately. Good to hear a real Spark 3.5.8 batch job runs through the current launcher. The two items you list as unverified line up with open review points, so here is what I still need before signing off on `d3d34f292`: 1. **Windows launcher** — the delayed-expansion issue means the script compares literal strings and never calls the assembled command, and the loop swallows the starter's real exit code when it fails with no output. Please push a fix for both and run the script once on an actual Windows machine; "unverified" isn't enough for an entry point we ship. 2. **Micro-batch streaming on Spark 3.5.8** — the docs point Spark 3.5 users at the streaming template, but the reused 3.3 translation layer has only been exercised for batch. A streaming test in the Spark 3.5 module (or at minimum a manual run with the output pasted here) would cover this. 3. **Remaining points** — I have no update yet on the shell launcher's eval of a config-derived command line and its unquoted argument/classpath variables, the Spark 3.5 starter reusing the 3.3 translation module, the dual SLF4J 1.x/2.x log4j bindings in the logging jar list, or the Spark 3.4.x documentation gap. Could you either address these in the next commit or reply per item with why you'd prefer to leave them as-is? Once those land I'll re-review the new head. <!-- streview-comment:1107 --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
