DanielLeens commented on PR #12298: URL: https://github.com/apache/seatunnel/pull/12298#issuecomment-5726066979
@SEZ9 Thanks for both updates. On the `SplitClusterFaultToleranceIT` correction: good catch on the carry-forward artifact, and thanks for tracking the corrected 4/8 vs 8/8 vs 1/1 numbers down to #12353 with a real mechanism rather than leaving it as a suite-size guess. That's a materially better outcome than my "3/3 passing" read too — glad it's landed on `failedTaskNum > 0` priority in `SubPlan.getPipelineEndState()` with #12311 as the fix. Agreed this changes nothing about #12298 itself: everything this diff touches is green, and #12344 is the only thing actually gating merge on the CI side. On the recap: that matches exactly where I landed in my last pass — Item 1 (per-node bound-port state instead of mutating the shared `HttpConfig` bean) is the one blocking item, items 2-6 are the small follow-ons, and CI is a non-issue for this diff specifically. Nothing to add on my side; I'll take a fresh look as soon as the refactor is pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
